[Webkit-unassigned] [Bug 40082] [Qt] Dropdown box is seen twice in a webpage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40082


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58719|review?                     |review-
               Flag|                            |




--- Comment #11 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-12-24 02:38:48 PST ---
(From update of attachment 58719)
View in context: https://bugs.webkit.org/attachment.cgi?id=58719&action=review

The comment is very very detailed and not get out of touch with the code. In WebKit we like comments to be concise and to the point.

Btw, is this still an issue? Can it be fixed in Qt?

> WebKit/qt/WebCoreSupport/QtFallbackWebPopup.cpp:72
> +    void paint(QPainter*, const QStyleOptionGraphicsItem*, QWidget*) {}

Needs space between { and }. WebKit coding style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.