[Webkit-unassigned] [Bug 51176] sheriff-bot should be able to do multi-revision rollouts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51176


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76757|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2010-12-24 01:48:49 PST ---
(From update of attachment 76757)
View in context: https://bugs.webkit.org/attachment.cgi?id=76757&action=review

Needs another round. :)

> WebKitTools/Scripts/webkitpy/tool/bot/irc_command.py:64
> +        read_revision = True
> +        rollout_reason = []
> +        # the first argument must be a revision number
> +        svn_revision_list = [args[0].lstrip("r")]
> +        if not svn_revision_list[0].isdigit():
> +            read_revision = False
> +

Please split this (arg parsing, etc.) into private (_foo()) helper functions instead of just making execute longer.

> WebKitTools/Scripts/webkitpy/tool/bot/sheriff.py:58
> +            svn_revisions = " ".join([str(int(revision)) for revision in svn_revision_list])

Um, why do str(int(?

> WebKitTools/Scripts/webkitpy/tool/bot/sheriff.py:76
> +            svn_revisions,

Please pass them individually as numbers converted to strings, instead of as a joined string.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.