[Webkit-unassigned] [Bug 51116] Building webkit with Visual Studio 2010 fails due to ambiguous 'operator =' methods in RefPtr.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51116





--- Comment #16 from Jake <jake at jakeonthenet.com>  2010-12-23 16:50:11 PST ---
(In reply to comment #15)
> (From update of attachment 77384 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77384&action=review
> 
> The rest of my comments from the first patch still apply, except for the one about the tab.
> 
> > WebCore/dom/Document.cpp:3175
> > -            newFocusedNode = 0;
> > +            newFocusedNode = (Node*) 0;
> 
> This change looks wrong. Could you tell me more about the warning?

Darin you're too fast! I posted the second patch while you were reviewing my first one :)

Regarding the (Node*) 0 issue, for some reason those two lines in Document.cpp failed to compile without the cast.

And sorry about the geolocation thing. It wasn't meant to be included. I'll post a new patch in a couple of minutes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.