[Webkit-unassigned] [Bug 51116] Building webkit with Visual Studio 2010 fails due to ambiguous 'operator =' methods in RefPtr.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51116


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77383|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #13 from Darin Adler <darin at apple.com>  2010-12-23 16:39:36 PST ---
(From update of attachment 77383)
View in context: https://bugs.webkit.org/attachment.cgi?id=77383&action=review

Thanks for the patch. Patches need to include change logs. Please submit a new version with a change log.

> JavaScriptCore/wtf/NullPtr.h:36
> +// Don't declare this when building with visual studio 2010+
> +
> +#if !defined(_MSC_VER) || _MSC_VER < 1600

This should go a few lines down:

    #if !__has_feature(cxx_nullptr) && (!defined(_MSC_VER) || _MSC_VER < 1600)

No need to add an extra level of #if.

> JavaScriptCore/wtf/RefPtr.h:77
> +		template<typename U> RefPtr& operator=(const RefPtr<U>&);

Can't land a patch with tabs in it.

> WebCore/dom/ViewportArguments.h:77
> +        , userScalable((bool) ValueAuto)

This fix is incorrect. Bug 50982 has a reviewed patch already in the commit queue to fix this.

> WebCore/page/Geolocation.h:159
> +    class PositionCacheWrapper {
> +    public:
> +        PositionCacheWrapper()
> +        {
> +        }
> +        ~PositionCacheWrapper()
> +        {
> +        }
> +        void setCachedPosition(Geoposition* cachedPosition) {}
> +        Geoposition* cachedPosition() {return 0;}
> +    };

Adding an entire new copy of the class is not the optimal way to fix this. I believe platforms that are not implementing Geolocation should not be compiling this file at all.

This seems unrelated to the compiler and should not be lumped in with the compiler-specific fixes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.