[Webkit-unassigned] [Bug 51382] [Chromium]Issue 60427: Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field. http://crbug.com/60427

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51382





--- Comment #24 from Naoki Takano <takano.naoki at gmail.com>  2010-12-23 13:53:23 PST ---
(From update of attachment 77302)
View in context: https://bugs.webkit.org/attachment.cgi?id=77302&action=review

> WebCore/ChangeLog:20
> +

Ok,

> WebCore/platform/chromium/PopupMenuChromium.cpp:344
>  

Yes, "calculateWidgetRect()" has side effect. Because the function uses "layout()". So do you imply I should make "calculateWidgetRect()" have no side effect?

> WebCore/platform/chromium/PopupMenuChromium.cpp:369
> +                widgetRect = chromeClient->windowToScreen(windowRect);

I need more investigation. Because "layout()" has side effect and widgetRect might be change according to "layout()" call. The original code also recalculate here, so that's why I remained this line.

> WebCore/platform/chromium/PopupMenuChromium.cpp:444
> +{

Ok,

> WebCore/platform/chromium/PopupMenuChromium.h:200
> +    IntRect calculateWidgetRect(const IntRect& targetFrameRect);

Ok,

> WebCore/platform/chromium/PopupMenuChromium.h:215
>  };

m_popupRect is different from frameRect().
Because frameRect() is variable according to setFrameRect().
But this m_popupRect is saved as the first original position and rect of input text position.

Or do you mean other problem?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.