[Webkit-unassigned] [Bug 51548] New: check-webkit-style doesn't check all of the ports when linting test expectations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51548

           Summary: check-webkit-style doesn't check all of the ports when
                    linting test expectations
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dpranke at chromium.org
                CC: eric at webkit.org, abarth at webkit.org, ojan at chromium.org,
                    levin at chromium.org


The code in the TestExpectations style checker only lints the test expectations file against the port it is running on. It really should be linting against all ports, like new-run-webkit-tests --lint-test-files does.

The easiest fix is to just have it call into the lint routines in webkitpy/layout_tests ... I should probably refactor that logic out of TestRunner and into test_expectations.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.