[Webkit-unassigned] [Bug 51186] [chromium] Add asserts to test for contiguous-pixel Skia bitmaps.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51186


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77333|review?                     |review-
               Flag|                            |




--- Comment #10 from Kenneth Russell <kbr at google.com>  2010-12-23 08:01:53 PST ---
(From update of attachment 77333)
View in context: https://bugs.webkit.org/attachment.cgi?id=77333&action=review

The "if" with an ASSERT as its sole arm is sloppy.

> WebCore/platform/graphics/chromium/ImageLayerChromium.cpp:125
> +        ASSERT(skiaBitmap->rowBytes() == SkBitmap::ComputeRowBytes(skiaConfig, skiaBitmap->width()));

ASSERT(!pixels || (skiaBitmap->rowBytes() == ...))

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.