[Webkit-unassigned] [Bug 51509] [Qt] [Symbian] Fix build-webkit script for Symbian

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51509


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77281|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2010-12-23 01:03:51 PST ---
(From update of attachment 77281)
View in context: https://bugs.webkit.org/attachment.cgi?id=77281&action=review

Review tool can't seem to apply the patch, so I doubt this will land w/o an update.

> Tools/Scripts/webkitdirs.pm:303
> +        # Symbian builds do not have Release/Debug configurations either.
> +        if (($ENV{"WEBKITOUTPUTDIR"} && (isGtk() || isEfl())) || isSymbian()) {

We need to make this into a function.  usesPerConfigurationBuildDirectory() or similar.

> Tools/Scripts/webkitdirs.pm:1526
> -    my $dir = File::Spec->canonpath(baseProductDir());
> -    $dir = File::Spec->catfile($dir, $config) unless isSymbian();
> +    my $dir = File::Spec->canonpath(productDir());

Is this a symbian specific code path? Otherwise why is this OK for other ports?

> Tools/Scripts/webkitdirs.pm:1532
> -    push @buildArgs, "OUTPUT_DIR=" . baseProductDir() . "/$config";
> +    push @buildArgs, "OUTPUT_DIR=" . $dir;

Why is this OK for other ports?  Or is this just reverting previously added symbian-specific code?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.