[Webkit-unassigned] [Bug 51490] Cleanup SVG code according to the webkit style rules 3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51490


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77309|review?                     |review+
               Flag|                            |




--- Comment #9 from Andreas Kling <kling at webkit.org>  2010-12-23 01:01:05 PST ---
(From update of attachment 77309)
View in context: https://bugs.webkit.org/attachment.cgi?id=77309&action=review

r=me with one small thing and one medium:

> WebCore/ChangeLog:8
> +        Last patch to fix indention and other style issues according to the WebKit style rules in the SVG code.

s/indention/indentation/

> WebCore/svg/SVGSVGElement.cpp:133
> -    double _x = 0.0;
> -    double _y = 0.0;
> +    double m_x = 0.0;
> +    double m_y = 0.0;

This looks quite wrong, m_x and m_y are member variables, and you are shadowing them here.
Use better names please :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.