[Webkit-unassigned] [Bug 44759] [EFL] Add custom network resource handler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44759


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66764|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #11 from Adam Barth <abarth at webkit.org>  2010-12-23 00:32:59 PST ---
(From update of attachment 66764)
View in context: https://bugs.webkit.org/attachment.cgi?id=66764&action=review

> WebCore/loader/FrameLoader.cpp:3546
> +#if PLATFORM(EFL)
> +bool FrameLoaderClient::shouldHandleScheme(const String& scheme)
> +{
> +    return false;
> +}
> +
> +void* FrameLoaderClient::handleScheme(const KURL url, String& mime, size_t* bytesRead)
> +{
> +    return 0;
> +}
> +#endif

FrameLoaderClient functions should not be implemented in FrameLoader.cpp.  They should be implemented in the client.

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:611
> +#if PLATFORM(EFL)
> +    if (frame->loader()->client()->shouldHandleScheme(protocol)) {
> +        if (startCustomHandler(this, url))
> +            return true;
> +    }
> +#endif

Why is this EFL specific?  The point of clients is to allow for different behavior between ports without #ifs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.