[Webkit-unassigned] [Bug 48926] Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48926


Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpranke at chromium.org




--- Comment #22 from Dirk Pranke <dpranke at chromium.org>  2010-12-22 19:21:25 PST ---
For what it's worth, this patch should've had a test added to webkitpy/layout_tests/layout_package/test_expectations.py .

And, there's no need to be duplicating all of this unit testing logic in two different files. The style checker file should just be a trivial wrapper that creates a TestExpectations object and logs any errors that occur. 

I stumbled across this duplication (yet again) while testing the changes for bug 51222. I wouldn't be surprised if some of the style checking testing predated some of the unit tests, and prior to the cleanup in 51222, figuring out if things linted correctly was a little harder than it should be. I'll submit a separate patch to de-dup the code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.