[Webkit-unassigned] [Bug 50867] [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50867





--- Comment #12 from Koan-Sin Tan <koansin.tan at gmail.com>  2010-12-22 16:18:06 PST ---
(In reply to comment #11)
> (From update of attachment 77178 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77178&action=review
> 
> > Tools/DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:38
> > +#if OS(DARWIN) && PLATFORM(GTK)
> > +#define Cursor       QD_Cursor 
> > +#endif
> >  #include "PluginObject.h"
> > +#if OS(DARWIN) && PLATFORM(GTK)
> > +#undef Cursor
> > +#endif
> >  #include "PluginTest.h"
> >  
> >  #include "npapi.h"
> 
> Where is Cursor referenced? It probably makes sense to do this closer to that place.

somewhere in #include "PluginObject.h", I'l dig it out.
And #include <X11/Xlib.h> will define Cursor again.
So, must #undef it before X11/Xlib.h

> > Tools/Scripts/webkitdirs.pm:600
> > -        if (-e $libraryDir . "libwebkitgtk-3.0.so") {
> > +        if (isDarwin() and -d "$libraryDir") {
> > +            return $libraryDir . "libwebkitgtk-1.0.dylib";
> > +        } elsif (-e $libraryDir . "libwebkitgtk-3.0.so") {
> >              return $libraryDir . "libwebkitgtk-3.0.so";
> 
> You don't properly handle the GTK+ 2.x case here.
> 

I don't understand the GTK+ 2.x case, can you tell me more?

> 
> Should be 'Darwin'. :)
>

Thanks, will fix it.

> > WebCore/ChangeLog:13
> > +        * config.h: (OS(DARWIN) && PLATFORM(GTK)) doesn't like ctypes
> 
> It's hard for me to understand exactly what the issue is here. Where does OS(DARWIN) && PLATFORM(GTK) use ctypes, that it breaks the build to disallow them.
>

I forgot the detail, will dig it out.

> 
> You've added an extra !PLATFORM(CHROMIUM).
>

I'll fix it, thanks.

> > WebCore/platform/UUID.cpp:35
> > +#if OS(DARWIN) && PLATFORM(GTK)
> > +#define WTF_PLATFORM_CF 1
> > +#endif
> >  #include "UUID.h"
> 
> It seems really unusual to do something like that and do it before the second include. Maybe there's a cleaner way to do it?

move it into UUID.h? must define this before #include "PlatformString.h", which is the first include in UUID.h

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.