[Webkit-unassigned] [Bug 50833] [chromium] Add support to compositor to composite to offscreen texture.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50833


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
         AssignedTo|webkit-unassigned at lists.web |wjmaclean at chromium.org
                   |kit.org                     |
     Ever Confirmed|0                           |1




--- Comment #25 from Kenneth Russell <kbr at google.com>  2010-12-22 12:47:55 PST ---
(In reply to comment #24)
> (In reply to comment #23)
> > (From update of attachment 77114 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=77114&action=review
> > 
> > > WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:682
> > > +    }
> > 
> > This logic only handles the transition from m_compositeOffscreen from false to true. What about the other direction?
> 
> It should work both ways. m_compositeOffscreen is set to whatever the value of the argument to setCompositeOffscreen says, but can be overriden is m_rootLayer is false.
> 
> Resources allocated going from false to true aren't necessarily de-allocated going from true to false, but it does go back to rendering direct to screen.
> 
> Is that what you were wondering about?

Yes, I was essentially wondering about the setting of the layer renderer for the root layer and any associated resources attached to the root layer. It would be good to clean up all of these resources upon the true -> false transition. What do you think about doing this work in this patch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.