[Webkit-unassigned] [Bug 51474] [Qt][WK2] WebProcess does not clean up on termination

Wed Dec 22 11:33:45 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=51474

Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77241|review+                     |review-
               Flag|                            |

--- Comment #6 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-12-22 11:33:45 PST ---
(From update of attachment 77241)
View in context: https://bugs.webkit.org/attachment.cgi?id=77241&action=review

I think Kimmo should look at this before it is being committed. Also I do not like that you do renaming and all these changes in the same patch... it is very hard to see what was actually changed. The rename could easily be another patch. R- for this reason.

> WebKit2/Platform/qt/SharedMemoryQt.cpp:139
> +    // Do not leave behind the shared memory segment!

Comments should not end with ! They should just be informative.

> WebKit2/Platform/qt/SharedMemoryQt.cpp:147
> +    CleanupHandler::instance()->willDelete(m_impl);

I do not like the name willDelete... I dont understand what it actually does.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.