[Webkit-unassigned] [Bug 51313] [Qt] Baseline qt_minimal configuration

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51313


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76967|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #5 from Csaba Osztrogonac <ossy at webkit.org>  2010-12-22 10:31:39 PST ---
(From update of attachment 76967)
View in context: https://bugs.webkit.org/attachment.cgi?id=76967&action=review

Great patch, thanks for it. ;) Please fix typos and QT_NO_BEARERMANAGEMENT before landing.
(I tested the patch, QtTestBrowser works fine.)

> ChangeLog:9
> +        * WebKit.pri: List the supported QT_NO_FUTURE flags
> +        under qt_minial configuration.

s/QT_NO_FUTURE/QT_NO_FEATURE
s/minial/minimal

> Tools/QtTestBrowser/launcherwindow.h:79
> +class QPropertyAnimation;
> +

Why do we need it?

> WebKit.pri:118
> +    DEFINES *= QT_NO_BEARERMANAGEMENT

To use QT_NO_BEARERMANAGEMENT we need one more little patch. Including of 
moc_NetworkStateNotifierPrivate.cpp should be inside the ENABLE(BEARER) guard:

diff --git a/WebCore/platform/network/qt/NetworkStateNotifierQt.cpp b/WebCore/platform/network/qt/NetworkStateNotifierQt.cpp
index 959e74a..f3e7023 100644
--- a/WebCore/platform/network/qt/NetworkStateNotifierQt.cpp
+++ b/WebCore/platform/network/qt/NetworkStateNotifierQt.cpp
@@ -91,6 +91,6 @@ void NetworkStateNotifier::setNetworkAccessAllowed(bool isAllowed)

 } // namespace WebCore

-#endif
-
 #include "moc_NetworkStateNotifierPrivate.cpp"
+
+#endif

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.