[Webkit-unassigned] [Bug 51354] Don't block rendering and script execution on deferred stylesheets

Wed Dec 22 05:46:02 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=51354

--- Comment #16 from Antti Koivisto <koivisto at iki.fi>  2010-12-22 05:46:02 PST ---
(In reply to comment #14)
> HTMLLinkElement::removePendingSheet() doesn't check m_loading - is it OK to remove the check?
> Can ASSERT_NOT_REACHED() be added here?

Yea and no. The m_loading check was part of the fragile state management in the old code. This patch keeps track of whether we made the request in the first place so the m_loading check (and other similar checks) can be removed. That None check is equivalent of the m_loading check and so a valid case.

> I think that the new code would read better if this was a boolean variable - "type" doesn't really mean anything. Looks like type None sheets shouldn't ever be pending, so switching to a boolean would also make understanding this code easier.

I found it difficult to represent three states with a boolean.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.