[Webkit-unassigned] [Bug 51446] New: ContextShadow uses inaccurate kernel size computation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51446

           Summary: ContextShadow uses inaccurate kernel size computation
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: simon.fraser at apple.com
                CC: ariya.hidayat at gmail.com, mrobinson at webkit.org


The SVG spec, and FEGaussianBlur, compute the kernel size by multiplying the blur radius by
  gGaussianKernelFactor = 3 / 4.f * sqrtf(2 * piFloat)

which becomes, in blurLayerImage,
-    int d = max(2, static_cast<int>(floorf((2 / 3.f) * m_blurDistance)));
+    int d = max(2, static_cast<int>(floorf(m_blurDistance / 2 * GaussianKernelFactor + 0.5f)));

This gives a more accurate radius for small shadows. It's noticeable on a 5px shadow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.