[Webkit-unassigned] [Bug 51407] A check should be in place to ensure that a media engine error has not occurred after MediaPlayer::play() is called

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51407





--- Comment #2 from Lukas Sydorowski <lsydorowski at rim.com>  2010-12-21 12:14:25 PST ---
(In reply to comment #1)
> (From update of attachment 77130 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77130&action=review
> 
> > WebCore/ChangeLog:8
> > +        No new tests required.
> 
> Why? The WebKit project requires tests for all bug fixes unless there is some reason a test is impossible or impractical. If this has no effect observable in a test, then why would we make the code change?

A test would only make sense in testing a media engine failure at this stage of execution, which may very well be platform dependent depending on how media rendering is performed on the particular platform. If there is a way to "fake" a media engine failure in the tests that is NOT platform dependent (such as making a call to mediaEngineError() at this point - Is this actually possible?), then I will write a test for this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.