[Webkit-unassigned] [Bug 51410] New: webkit-patch open-bugs does not correctly ignore dates

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51410

           Summary: webkit-patch open-bugs does not correctly ignore dates
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org


webkit-patch open-bugs does not correctly ignore dates

If you try something like:
curl -L http://webkit.org/pending-commit | webkit-patch open-bugs

You end up opening a zillion bugs number 2010.


I don't quite have enough regexp foo to know how to fix it.

I'd like to add (and fix the first two of) the following unit tests:

diff --git a/Tools/Scripts/webkitpy/tool/commands/openbugs_unittest.py b/Tools/Scripts/webkitpy/tool/commands/openbugs_unittest.py
index 40a6e1b..0543155 100644
--- a/Tools/Scripts/webkitpy/tool/commands/openbugs_unittest.py
+++ b/Tools/Scripts/webkitpy/tool/commands/openbugs_unittest.py
@@ -38,6 +38,12 @@ class OpenBugsTest(CommandsTest):
         ["123456", ["123456"]],
         ["1234567", []],
         [" 123456 234567", ["123456", "234567"]],
+        # Make sure we don't treat dates as bug numbers.
+        ["2010-10-20 2000", ["2000"]],
+        ["10/20/2010 2000", ["2000"]],
+        # There is no easy way to ignore this one, except maybe ignore
+        # all numbers between 1999 and 2012?
+        ["December 20th 2010 2000", ["2010", "2000"]],
     ]

     def test_find_bugs_in_string(self):


One way to cut down on the zillions of bugs would be to use a set to unique the set of parsed bug numbers...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.