[Webkit-unassigned] [Bug 51354] Don't block rendering and script execution on deferred stylesheets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51354


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77101|review?                     |review+
               Flag|                            |




--- Comment #14 from Alexey Proskuryakov <ap at webkit.org>  2010-12-21 08:57:08 PST ---
(From update of attachment 77101)
View in context: https://bugs.webkit.org/attachment.cgi?id=77101&action=review

Please do update the comment in Document.h that says "Track the number of currently loading top-level stylesheets."

> WebCore/html/HTMLLinkElement.cpp:235
> -            if (m_loading)
> -                document()->removePendingSheet();
> +            removePendingSheet();

HTMLLinkElement::removePendingSheet() doesn't check m_loading - is it OK to remove the check?

> WebCore/html/HTMLLinkElement.cpp:467
> +    if (type == None)
> +        return;

Can ASSERT_NOT_REACHED() be added here?

> WebCore/html/HTMLLinkElement.h:139
> +    PendingSheetType m_pendingSheetType;

I think that the new code would read better if this was a boolean variable - "type" doesn't really mean anything. Looks like type None sheets shouldn't ever be pending, so switching to a boolean would also make understanding this code easier.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.