[Webkit-unassigned] [Bug 51374] Cairo's ContextShadow may mis-render some box shadows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 21 03:55:49 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=51374





--- Comment #5 from Alejandro G. Castro <alex at igalia.com>  2010-12-21 03:55:49 PST ---
(In reply to comment #2)
> I think the top of ContextShadow::drawRectShadow() should read:
> 
> [...]
>
>     if ((!context->getCTM().isIdentityOrTranslationOrFlipped()) || (shadowTemplateSize.width() > rect.width())
>         || (shadowTemplateSize.height() > rect.height()) || (m_type != BlurShadow)) {
>         drawRectShadowWithoutTiling(cgContext, rect, topLeftRadius, topRightRadius, bottomLeftRadius, bottomRightRadius, 1);
>         return;
>     }

You are right, the problem is the calculation of the internal space required for the corner shadows, I've refactored the code with your proposal in the patch. Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list