[Webkit-unassigned] [Bug 51241] [GTK] PlatformRefPtr should not be used with Gtk widgets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51241





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2010-12-20 22:59:27 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > Is this necessarily an error for non-toplevel widgets?
> 
> It's not necessarily an error, you keep a reference, so that when the widget is desroyed you still have the reference and when PlatormRefPtr release the last reference the widget is finally destroyed. But that's not how we expect gtk+ widgets to work. PlatformRefPtr is supposed to be for taking the ownership of objects to release them when they are not needed anymore, gtk+ already does that for widgets, you create a widget, add it to a container and forget about it. 

In this case it should still be appropriate for situations where WebKit wants to control the lifetime of the GTK+ object or if it's shared between WebKit classes. For instance, ContextMenu isn't copyable, but if it was we would want the menu widget to be a PlatformRefPtr.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.