[Webkit-unassigned] [Bug 51151] NSScrollView-based scrollbars and ScrollBarTheme-based scrollbars don't look the same

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51151


Mihai Parparita <mihaip at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jam at chromium.org




--- Comment #17 from Mihai Parparita <mihaip at chromium.org>  2010-12-20 19:57:57 PST ---
(In reply to comment #16)
> 1. Yes, we can have two different scrollbar drawing implementations. It may solve a real problem. That doesn't mean it doesn't give me a bad feeling and scream "backward-looking". My gut says that fixing the top-level scrollbar != other scrollbar problem for Safari and rebaselining everything is a real solution and that this is just a hack.

Yes, this is a hack, but it seems preferable to either not looking at the results of hundreds of tests or maintaining parallel baselines for them.

> 2. You're doing WebThemeEngine for the Mac? Wasn't jam working on that? 

Not sure, adding him to the bug.

> There is no way to draw the separate pieces of a scrollbar on the Mac (arrows, track, etc) with HITheme. Almost certainly not with the public API of NSScroller either.

The only part that's actually different is the thumb, so that's the only part we'd need to move into WebThemeEngineMac. We already draw that separately with HITheme:

http://trac.webkit.org/browser/trunk/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm#L450

And NSScroller has drawKnob: http://developer.apple.com/library/mac/#documentation/Cocoa/Reference/ApplicationKit/Classes/NSScroller_Class/Reference/Reference.html#//apple_ref/occ/instm/NSScroller/drawKnob

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.