[Webkit-unassigned] [Bug 51151] NSScrollView-based scrollbars and ScrollBarTheme-based scrollbars don't look the same

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51151





--- Comment #13 from Mihai Parparita <mihaip at chromium.org>  2010-12-20 16:09:51 PST ---
Avi and I chatted about this, and he feels like the right thing to do is to ge the Safari/Mac port (or at least its DRT) off of NSScrollView for the root scrollable area, so that it matches the other ports.

However, from talking to James, I realized that that means a mass rebaseline (in platform/mac and platform/mac-leopard) of all layout tests that have scrollbars in them. The whole point of Dimitri's and my exploration in this area is to get Chromium/Mac to match Safari/Mac so that we can use the existing baselines. If we're going to be doing a mass rebaseline anyway, we might as well just maintain platform/chromium-mac baselines with our different scrollbar rendering (since we're already down that path -- we started with ~400 scrollbar-related failures in platform/chromium/test_expectations.txt and are now down to 229).

Avi, how about I limit the scope of this patch to only use NSScroller when running under the Chromium DRT _and_ we're rendering the top-level scrollbar? That way any brittleness will be isolated. I'm also open to any suggestions that you might have to lessen that (e.g. can we get at the real NSWindow that we're in, instead of needing FakeActiveWindow?)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.