[Webkit-unassigned] [Bug 49750] [Qt] Compile with QT_NO_GRAPHICSVIEW

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 19 21:09:49 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=49750


Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74261|review?                     |review-
               Flag|                            |




--- Comment #2 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2010-12-19 21:09:49 PST ---
(From update of attachment 74261)
View in context: https://bugs.webkit.org/attachment.cgi?id=74261&action=review

The patch does not seem to apply r- for that (file WebKit/qt/ChangeLog).

How have you tested the patch ?

> WebKit/qt/WebCoreSupport/PageClientQt.cpp:119
> +#if !defined(QT_NO_GRAPHICSVIEW)

Is this needed if USE(ACCELERATED_COMPOSITING) or USE(TEXTURE_MAPPER) is false ?

> WebKit/qt/WebCoreSupport/PageClientQt.cpp:259
> +#if !defined(QT_NO_GRAPHICSVIEW)

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list