[Webkit-unassigned] [Bug 51308] New: no-caret-repaint-in-non-content-editable-element.html does not need to disable CaretBrowsing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 19 14:10:33 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=51308

           Summary: no-caret-repaint-in-non-content-editable-element.html
                    does not need to disable CaretBrowsing
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tonikitoo at webkit.org


no-caret-repaint-in-non-content-editable-element.html is the only test that explicitly disables caret browsing.

...
if (window.layoutTestController)
    layoutTestController.overridePreference("WebKitEnableCaretBrowsing", false);
...

However, this is a useless statement, since all DRT that support testing caret browsing (gtk, qt anc chromium) have it reset by default to FALSE before each test execution. On Mac and Windows, DRT that do not support testing caret browsing, it is obviously also FALSE by default.

I propose removing it.

Patch coming ...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list