[Webkit-unassigned] [Bug 51161] [Qt] Blur distance should not be affected by scaling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51161





--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2010-12-18 20:12:34 PST ---
(From update of attachment 76950)
View in context: https://bugs.webkit.org/attachment.cgi?id=76950&action=review

Very nice. A couple nits below.

> WebCore/platform/graphics/ContextShadow.cpp:177
> +    if (!transform.isIdentity()) {

I think this is a good place to use an early return.

> WebCore/platform/graphics/cairo/ContextShadowCairo.cpp:97
>      double x1, x2, y1, y2;
>      cairo_clip_extents(context, &x1, &y1, &x2, &y2);
> +    adjustBlurDistance(context);

Maybe move the third line above the first two lines? The clip extents are only used for the call to calculateLayerBoundingRect, so this is in the middle of another "sentence" so to speak.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.