[Webkit-unassigned] [Bug 51296] [Qt] [WK2] Client are expected to render their own background for WebPages

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 18 14:02:45 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=51296


Benjamin Poulain <benjamin.poulain at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76942|                            |review?, commit-queue?
               Flag|                            |




--- Comment #1 from Benjamin Poulain <benjamin.poulain at nokia.com>  2010-12-18 14:02:44 PST ---
Created an attachment (id=76942)
 --> (https://bugs.webkit.org/attachment.cgi?id=76942&action=review)
Patch

Kenneth, this is similar to the patch you made. There are the following differences:

-remove the call to painter->drawRect(area). This was only drawing 1px border, which is wrong in my opinion
-use QPainter::filerRect() instead of ::drawRect(). ::drawrect has to take into account the pen, ::fillRect is just a memfill in this case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list