[Webkit-unassigned] [Bug 51293] WebKit does not build with worker but without the javascript debugger

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 18 13:21:36 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=51293


Benjamin Poulain <benjamin.poulain at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76941|                            |review?, commit-queue?
               Flag|                            |




--- Comment #1 from Benjamin Poulain <benjamin.poulain at nokia.com>  2010-12-18 13:21:36 PST ---
Created an attachment (id=76941)
 --> (https://bugs.webkit.org/attachment.cgi?id=76941&action=review)
Patch

To fix the build, I could have modified the idl to move the two functions outside of ENABLE_JAVASCRIPT_DEBUGGER, like they were before #51025.

Instead I added guards in InspectorController. Those two functions are in the context of the Debugger, so the change of #51025 make sense in my opinion, and we can remove the calls to those methods.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list