[Webkit-unassigned] [Bug 51152] <select> elements don't honor border:0px in chromium-linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51152





--- Comment #4 from dgrogan at google.com  2010-12-17 13:16:49 PST ---
(In reply to comment #3)
> (Note: I am not a WebKit reviewer. You need an r+ from a real reviewer as well.)
> 
> Code change LGTM. I'm not sure about the CSS.
> 
> The background colour in the CSS replaces the default system colour of selects and allows us to assume that we always have a CSS colour in the code.

Wouldn't the select entry in html.css that sets background-color: white also allow the code to make that assumption?
https://trac.webkit.org/browser/trunk/WebCore/css/html.css?rev=73613#L507
This is probably more complicated than I initially thought; I'm ok with keeping it as-is.

> Adding border: 0px seems wrong. Is the Windows default to have no border?

I agree that border:0px seems wrong.  This change removes it.  (I think you misread the patch:)  Windows defaults to a border of 1px.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.