[Webkit-unassigned] [Bug 51110] IDBCursor::delete is not implemented.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51110


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76877|review?                     |review+
               Flag|                            |




--- Comment #5 from Jeremy Orlow <jorlow at chromium.org>  2010-12-17 10:00:20 PST ---
(From update of attachment 76877)
View in context: https://bugs.webkit.org/attachment.cgi?id=76877&action=review

r=me

> WebCore/storage/IDBIndexBackendImpl.cpp:109
> +    ASSERT(objectStore.get());

don't need .get()....u can probably combine both asserts since it's likely that they'll both be true or not

> WebCore/storage/IDBObjectStoreBackendImpl.cpp:309
> +    SQLiteStatement indexQuery(objectStore->sqliteDatabase(), "DELETE FROM IndexData WHERE objectStoreDataId = ?");

We have an index on this, right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.