[Webkit-unassigned] [Bug 51256] New: Fix test failures where NULL GeolocationClient is provided

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51256

           Summary: Fix test failures where NULL GeolocationClient is
                    provided
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit API
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jknotten at chromium.org


We need to test for NULL m_client on GeolocationClientProxy::geolocationDestroyed() as well because GeolocationClientProxy::geolocationDestroyed() is called unconditionally from the Page destructor.

e.g. webkit_unit_tests on Win. Test SelectPopupMenuTest.ShowThenHide

Backtrace:
    WebKit::GeolocationClientProxy::geolocationDestroyed [0x01E802D3+3] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\src\geolocationclientproxy.cpp:58)
Backtrace:
    WebKit::GeolocationClientProxy::geolocationDestroyed [0x01E802D3+3] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\src\geolocationclientproxy.cpp:58)
    WebCore::GeolocationController::~GeolocationController [0x015F3062+18] (d:\google-windows-2\chromium-win-release-tests\build\webcore\page\geolocationcontroller.cpp:46)
    WebCore::Page::~Page [0x0143CAC7+711] (d:\google-windows-2\chromium-win-release-tests\build\webcore\page\page.cpp:228)
    WebKit::WebViewImpl::close [0x01E5C330+96] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\src\webviewimpl.cpp:937)
    testing::TestInfo::Run [0x01E4D13D+269] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\testing\gtest\src\gtest.cc:2322)
    testing::TestCase::Run [0x01E4D2FF+239] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\testing\gtest\src\gtest.cc:2423)
    testing::internal::UnitTestImpl::RunAllTests [0x01E4D683+499] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\testing\gtest\src\gtest.cc:4199)
    testing::UnitTest::Run [0x01E4E0C9+137] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\testing\gtest\src\gtest.cc:3838)
    base::TestSuite::Run [0x01DE1468+216] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\base\test\test_suite.cc:127)
    main [0x0133AC75+37] (d:\google-windows-2\chromium-win-release-tests\build\webkit\chromium\tests\runalltests.cpp:54)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.