[Webkit-unassigned] [Bug 49345] [Chromium] Add a basic GestureManager to Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49345





--- Comment #19 from Robert Kroeger <rjkroege at chromium.org>  2010-12-16 16:49:34 PST ---
(From update of attachment 76281)
View in context: https://bugs.webkit.org/attachment.cgi?id=76281&action=review

>> WebCore/page/GestureManager.cpp:46
>> +
> 
> If you are passing the GM here anyways, why not putting these methods as class methods?

I chose to do this so that gesture functions could be added to this GM implementation without needing to modify it. In particular, platform or embedder code can add additional gestures given this structure.

>> WebCore/platform/PlatformWheelEvent.h:114
>> +        }
> 
> You should say in the changelog why you are adding this. (Or it could come on its own patch(?)

added in the next patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.