[Webkit-unassigned] [Bug 42943] WebKit fails to compile when building with WML support enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42943





--- Comment #18 from Joone Hur <joone at kldp.org>  2010-12-16 15:10:09 PST ---
(In reply to comment #12)
> Created an attachment (id=76395)
 --> (https://bugs.webkit.org/attachment.cgi?id=76395&action=review) [details]
> extending handleError signature -- not a regular patch
> 
> I propose this additional patch -- switches handleError method to TextPosition1. This patch does not fix the bug itself, only helps.
> 
> Joone, could you please try if it works for you? If it works, you can merge it with your change. I guess you will also need to convert your TextPosition0 (zero-based value) to TextPosition1 (one-based value expected in handleError), WTF::toOneBasedTextPosition can be used for this.
> 
> Peter

I tried to use TextPosition1 as follows,

parser->handleError(XMLDocumentParser::fatal, errorMessage.latin1().data(), toOneBasedTextPosition(parser->textPosition()).m_line.oneBasedInt(), toOneBasedTextPosition(parser->textPosition()).m_column.oneBasedInt());

It gives us wrong error report.

For example,

 16   <card id="card2" title="Answer">
*17     <p>You selected: $($$name)</p>
 18   </card>
 19 </wml

17 line has an error, so if we use TextPosition1, it reports the following error,

"This page contains the following errors:
error on line 18 at column 36: A variable reference uses invalid syntax.
Below is a rendering of the page up to the first error."

I guess that the error should be on line 17 at column 26.

If we use TextPosition0, it reports,

"This page contains the following errors:
error on line 17 at column 35: A variable reference uses invalid syntax.
Below is a rendering of the page up to the first error."

It seems right except the column number, but actually, is line 16 right if we use TextPosition0?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.