[Webkit-unassigned] [Bug 37369] [GTK] Enable building whatever already exists of WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37369


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76766|review+                     |review?
               Flag|                            |




--- Comment #73 from Martin Robinson <mrobinson at webkit.org>  2010-12-16 12:36:36 PST ---
(From update of attachment 76766)
View in context: https://bugs.webkit.org/attachment.cgi?id=76766&action=review

This patch is very close, but there are a couple issues to fix before it can land. I've commented below.

> WebCore/ChangeLog:-645
> -2010-12-15  Amruth Raj  <amruthraj at motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla at motorola.com>
> -
> -        Reviewed by Martin Robinson.
> -
> -        Changes to enable building WebKit2 for Gtk port
> -        (https://bugs.webkit.org/show_bug.cgi?id=37369)
> -
> -        No new functionality added or deleted. Only makefile change. Hence, no tests added.
> -
> -        * GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and added them to WebKit/gtk/GNUmakefile.am
> -        * platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h> and declare WEBKIT_API directly
> -

You shouldn't remove lines from the ChangeLog here. I'll fix this when landing.

> WebKit2/ChangeLog:-278
> -2010-12-15  Amruth Raj  <amruthraj at motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla at motorola.com>
> -
> -        Reviewed by Martin Robinson.
> -
> -        Changes to enable building WebKit2 for Gtk port.
> -        (https://bugs.webkit.org/show_bug.cgi?id=37369)
> -
> -        * GNUmakefile.am: Added. 
> -        * Scripts/generate-forwarding-headers.pl: For GTK port, taking 1 extra argument for copying network headers.
> -        * WebKit2Prefix.h: Included WebCore/config.h for GTK port as the first header file for WebKit2 sources files.
> -        * gtk: Added.
> -        * gtk/webkit2.pc.in: Added.
> -

Same issue.

> WebKitTools/ChangeLog:-195
> -2010-12-15  Amruth Raj  <amruthraj at motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla at motorola.com>
> -
> -        Reviewed by Martin Robinson.
> -
> -        Change generate-forwarding-headers.pl for GTK port usage 
> -        (https://bugs.webkit.org/show_bug.cgi?id=37369)
> -
> -        * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
> -

Ditto.

> WebKitTools/Scripts/webkitdirs.pm:1356
> +        } elsif ($opt =~ /^--webkit2/i ) {
> +            push @buildArgs, "--enable-webkit2";

This change seems unrelated. Are they necessary, or is it possible to just remove this before landing?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.