[Webkit-unassigned] [Bug 51161] [Qt] shadowBlur should not be affected by scaling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51161


Ariya Hidayat <ariya.hidayat at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76734|review?                     |review-
               Flag|                            |




--- Comment #2 from Ariya Hidayat <ariya.hidayat at gmail.com>  2010-12-16 09:23:23 PST ---
(From update of attachment 76734)
View in context: https://bugs.webkit.org/attachment.cgi?id=76734&action=review

Minor issues, otherwise LGTM.

> WebCore/ChangeLog:5
> +        [Qt] shadowBlur should not be affected by scaling

Although shadowBlur is the term used by the spec, I guess it's clearer if here we put e.g. "Shadow distance" instead.

> WebCore/platform/graphics/qt/ContextShadowQt.cpp:119
> +    // Adjust blur if we're scaling, since the radius must not be affected by transformations.

Seems that it is possible to refactor this to be usable for Cairo as well.

> WebCore/platform/graphics/qt/ContextShadowQt.cpp:142
> +        // Calculate X axis scale factor.
> +        const float xAxisHorizontalChange = transformedXAxisUnit.x() - transformedOrigin.x();
> +        const float xAxisVerticalChange = transformedXAxisUnit.y() - transformedOrigin.y();
> +        const float xAxisScale = sqrtf(xAxisHorizontalChange * xAxisHorizontalChange
> +                                       + xAxisVerticalChange * xAxisVerticalChange);
> +
> +        // Calculate Y axis scale factor.
> +        const float yAxisHorizontalChange = transformedYAxisUnit.x() - transformedOrigin.x();
> +        const float yAxisVerticalChange = transformedYAxisUnit.y() - transformedOrigin.y();
> +        const float yAxisScale = sqrtf(yAxisHorizontalChange * yAxisHorizontalChange
> +                                       + yAxisVerticalChange * yAxisVerticalChange);

This could be simplified using QVector2D.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.