[Webkit-unassigned] [Bug 50659] Enable Chromium mac to display a context menu.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50659





--- Comment #6 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-12-16 09:21:27 PST ---
(From update of attachment 76728)
View in context: https://bugs.webkit.org/attachment.cgi?id=76728&action=review

> WebKit/chromium/public/WebView.h:278
> +    

nit: avoid adding lines with just spaces

> WebKit/chromium/public/WebView.h:282
> +    virtual void showContextMenu(const WebAccessibilityObject& obj) = 0;

nit: the API header should not refer to implementation details, especially not
things in WebCore.  WebCore could change and no one would know to update this
comment.  it also doesn't help someone use the API correctly.

I think it might be more useful API-wise to generalize this method.  You could
generalize it like this:

  virtual void showContextMenu(const WebNode&, const WebPoint& position);

But, perhaps it would be better to create a sibling to WebNode::simulateClick:

  WEBKIT_API void simulateContextMenu();

Perhaps you should implement it using Node::dispatchSimulatedMouseEvent?  I'm
not certain about that though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.