[Webkit-unassigned] [Bug 51035] UCS2 encoding aliases should be defaulted to Big Endian

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51035


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aroben at apple.com




--- Comment #22 from Adam Roben (aroben) <aroben at apple.com>  2010-12-16 07:42:25 PST ---
(In reply to comment #20)
> This broke the hell out of GTK+ (> 100 tests failing), so I reverted it in r74186. In the future please play attention to massive breakage in the bots when landing patches.

It also broke Safari on Windows's location field, search field, and error pages. These features use the IWebFrame::load[Alternate]HTMLString APIs, which end up calling through WebFrame::loadHTMLString [1]. BSTRs appear to be encoded with UTF-16LE, but we pass just "utf-16" as the encoding name to the SubstituteData constructor.

It looks like WebKit2's WebPage has this same problem [2].

1. http://trac.webkit.org/browser/trunk/WebKit/win/WebFrame.cpp?rev=73430
2. http://trac.webkit.org/browser/trunk/WebKit2/WebProcess/WebPage/WebPage.cpp?rev=74164

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.