[Webkit-unassigned] [Bug 51082] execCommand('JustifyCenter') adds extra BR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51082





--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2010-12-15 19:14:37 PST ---
Thanks for the review!

(In reply to comment #2)
> (From update of attachment 76612 [details])
> Seems inelegant to me to add a <br> and then later remove it.

It really is. I'm not happy about that either. But we do this all ever the place in editing whenever we move paragraphs because ReplaceSelectionCommand and others require a placeholder. We could avoid doing this if we had used moveParagraphWithClones instead.

On a side note, we should really be using ApplyBlockElementCommand here because all we need to do is to wrap each paragraph with a div and ApplyBlockElementCommand does exactly that.  However, when I tried to deploy ApplyBlockElementCommand while working on this bug, I encountered numerous crashes and failures and I had to give up.  I'll come back to this issue later though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.