[Webkit-unassigned] [Bug 51087] WebKit2: Can't add files to an <input type=file>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51087


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76684|review?                     |review+
               Flag|                            |




--- Comment #7 from Anders Carlsson <andersca at apple.com>  2010-12-15 13:31:40 PST ---
(From update of attachment 76684)
View in context: https://bugs.webkit.org/attachment.cgi?id=76684&action=review

> WebKit2/Scripts/webkit2/messages.py:420
> +        'WebKit::WebOpenPanelParameters::Data': '"WebOpenPanelParameters.h"',

I don't think this is needed.

> WebKit2/Shared/WebOpenPanelParameters.cpp:52
> +{

I usually name the out parameter "result" here.

> WebKit2/Shared/WebOpenPanelParameters.h:60
> +    WebOpenPanelParameters(const Data&);

Please make this explicit.

> WebKitTools/MiniBrowser/mac/BrowserWindowController.m:540
> +    printf("runOpenPanel callback\n");

Please remove this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.