[Webkit-unassigned] [Bug 50635] [new-run-webkit-tests] expectations parsing is slow

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 15 12:52:06 PST 2010


--- Comment #29 from Dirk Pranke <dpranke at chromium.org>  2010-12-15 12:52:05 PST ---
(In reply to comment #28)
> (In reply to comment #27)
> > 
> > Oh I see what happened :) I made that change before doing the early return in the expand_tests code. It was needed in that case because path_isdir() was returning False and the wrong code path was taken, making two test-cases fail.
> > 
> > With the early return in expand_tests that dummy code in test.py is no longer needed.
> That makes sense. I remember doing something similarly before. Of course, my testing has reviewed that test.py is sensitive to where it is being run from (using a real layout_tests_dir()), which it shouldn't be.
> So, I'll upload a separate patch that fixes that and removes this line.

Oh, and add some tests to make sure that we handle directories with "." in them properly.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list