[Webkit-unassigned] [Bug 51013] [Chromium] Should implement EditorClientImpl::requestCheckingOfString()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51013


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76627|review?                     |review-
               Flag|                            |




--- Comment #9 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-12-15 12:44:59 PST ---
(From update of attachment 76627)
View in context: https://bugs.webkit.org/attachment.cgi?id=76627&action=review

> WebKit/chromium/public/WebTextCheckingResult.h:43
> +    static WebTextCheckingResult misspellingAt(int location, int length);
> +    static WebTextCheckingResult badGrammarAt(int location, int length);

these static methods need the WEBKIT_API prefix so that they can be exported from WebKit when it is built as a DLL.

please review:
http://www.mail-archive.com/webkit-dev@lists.webkit.org/msg13648.html

> WebKit/chromium/public/WebTextCheckingResult.h:46
> +    int type() const { return m_type; }

it is generally better to define an enum for things like this.  then add code to
AssertMatchingEnums.cpp to ensure that the API defined enums do not get out of sync
with the WebCore defined ones.

> WebKit/chromium/public/WebTextCheckingResult.h:47
> +    int location() const { return m_location; }

nit: i think it is more common to use the term "position" or "offset" in cases like this.

> WebKit/chromium/public/WebViewClient.h:177
> +    // WebView::respondCheckingOfString()

nit: this comment is incorrect

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.