[Webkit-unassigned] [Bug 50635] [new-run-webkit-tests] expectations parsing is slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50635





--- Comment #27 from Philippe Normand <pnormand at igalia.com>  2010-12-15 12:44:37 PST ---
(In reply to comment #26)
> (In reply to comment #25)
> > > > >> WebKitTools/Scripts/webkitpy/layout_tests/port/test.py:214
> > > > >> +        if path.find('.') != -1:
> > > > > 
> > > > > This is fine for now given that this is just for testing, but in the real webkit tree, we have the CSS2.1 directory, which we may want to add tests for in the future. Please add a FIXME to make this work for that case.
> > > > 
> > > 
> > > I had to make this change to actually make the tests pass...
> > > 
> > > 
> > I'm just surprised that you would need to make a change to test.py for the tests to pass. I'll have to look into that.
> 
> I guess I was justifiably surprised. That line actually causes test-webkitpy to fail for me, because my source tree is rooted in a directory with a "." in it (e.g. /src/foo.bar/WebKit/WebKitTools/...). However, if I comment out those two lines, it passes for me. What fails for you without those lines?

Oh I see what happened :) I made that change before doing the early return in the expand_tests code. It was needed in that case because path_isdir() was returning False and the wrong code path was taken, making two test-cases fail.

With the early return in expand_tests that dummy code in test.py is no longer needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.