[Webkit-unassigned] [Bug 45870] [reviewtool] should always show overall comments text box

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45870


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76614|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #21 from Adam Barth <abarth at webkit.org>  2010-12-15 10:46:52 PST ---
(From update of attachment 76614)
View in context: https://bugs.webkit.org/attachment.cgi?id=76614&action=review

I'm not sure happy with the new UI, but I think that's just because I fear losing control of the reviewtool and not because of any real substantive issue.  A couple nits below.  If you'd like to implement the auto-sizing of the status bubble, that would be great.

> BugsSite/code-review.js:266
> +  function openOverallComments(e) {
> +    document.querySelector('.overallComments textarea').className = 'open';
> +    document.querySelector('#statusBubbleContainer').className = 'wrap';
> +  }

Should we use jQuery here?

> BugsSite/code-review.js:287
> +    document.querySelector('.overallComments textarea').addEventListener('click', openOverallComments);

We really should use jQuery here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.