[Webkit-unassigned] [Bug 45870] [reviewtool] should always show overall comments text box

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45870





--- Comment #19 from Ojan Vafai <ojan at chromium.org>  2010-12-15 10:32:59 PST ---
(In reply to comment #18)
> I like the approach.  Is there a reason the buttons move when you expand the text field?  That seems like it might be slightly disorienting.

The statusBubble goes above the buttons just to save space. I tried keeping the buttons aligned right, but it looks really odd with the whitespace to the right of the statusBubble. The whitespace comes from the fact that the statusBubble is an iframe and not sized to it's content, which, as mentioned earlier, we could fix with postMessage or by implementing seamless.

We could not put the statusBubble above the buttons, but that gives less horizontal space for the comments section on small screens.

Alternately, I could just make the statusBubble smaller to actually fit it's current contents. Then in the future if we add more items we'll need to make it larger/smaller.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.