[Webkit-unassigned] [Bug 50833] [chromium] Add support to compositor to composite to offscreen texture.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50833





--- Comment #12 from Vangelis Kokkevis <vangelis at chromium.org>  2010-12-15 09:47:35 PST ---
(From update of attachment 76549)
View in context: https://bugs.webkit.org/attachment.cgi?id=76549&action=review

James, a couple more comments but overall I think it looks good.

> WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:303
> +    m_rootLayer->m_renderSurface->m_contentRect = IntRect(0, 0, m_rootLayerTextureWidth, m_rootLayerTextureHeight);

I think we can move the m_rootLayer's render surface creation to ::prepareToDrawLayers() and set the m_contentRect only when the m_rootLayerTextureWidth changes.

> WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:339
> +    m_rootLayer->m_renderSurface->m_scissorRect = rootScissorRect; // Do I need this?

No, you don't need to set the scissor rect here.  The render surface's scissor rect is the scissor rect that needs to be applied before drawing the completed surface to its own parent surface.

> WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:786
> +        renderingUpsideDown = !renderingUpsideDown;

I believe the correct logic here would be:

if (m_currentRenderSurface == m_defaultRenderSurface && ! m_compositeOffscreen)
  // flip the scissor
else
  // don't flip the scissor

In other words, I don't think you should be flipping the scissor for all non-root renderSurface's when you're rendering offscreen.

> WebCore/platform/graphics/chromium/LayerRendererChromium.h:162
> +    bool m_compositeOffscreen;

Need to provide a default value for this in the constructor.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.