[Webkit-unassigned] [Bug 51105] Improve feArithmeticFilter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51105


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76643|review?                     |review+
               Flag|                            |




--- Comment #7 from Dirk Schulze <krit at webkit.org>  2010-12-15 09:12:25 PST ---
(From update of attachment 76643)
View in context: https://bugs.webkit.org/attachment.cgi?id=76643&action=review

The code looks good. It's just sad, that you check m_type twice, but I also don't see another way without code duplication :-/ r=me

Just one note, "feArithmeticFilter" is not the best choice. "Improve 'arithmetic' operator on feComposite" or something like that. And plese fix the style issues.

> WebCore/ChangeLog:12
> +        The existing tests cover this feature.

How, since you didn't change the behavior but just the performance?!? ;-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.