[Webkit-unassigned] [Bug 51103] check-webkit-style should check for XML syntax errors in .vcproj/.vsprops files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51103





--- Comment #1 from David Levin <levin at chromium.org>  2010-12-15 06:54:19 PST ---
Sounds like you want a new checker.

Here's how to do that:

1. Add a new checker
  a. Create a file WebKitTools/Scripts/webkitpy/style/checkers/vc_proj.py
  b. Fill in the checker to do what you want. 
     i. Use WebKitTools/Scripts/webkitpy/style/checkers/text.py as a simple example.  
    ii. Name it something like VcProjChecker
  c. Create a simple unit test for it. ?(WebKitTools/Scripts/webkitpy/style/checkers/text_unittest.py is a nice example)


2. You need to teach the style checker about the new file type:
  a. In WebKitTools/Scripts/webkitpy/style/checker.py
      Add a new file type to
         class FileType:
      Something like VCPROJ
   b. Make CheckerDispatcher._file_type return this file type for vcproj/vsprops files.
   c. Make CheckerDispatcher._create_checker return your new checker: VCProjChecker

3. Enjoy the fact that these error will be caught automatically.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.