[Webkit-unassigned] [Bug 50762] [EFL] ContextMenu implementation is broken

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50762





--- Comment #3 from Lucas De Marchi <demarchi at webkit.org>  2010-12-15 02:55:31 PST ---
(In reply to comment #2)
> (From update of attachment 76537 [details])
> Is there a way you can do this without passing a ContextMenuController to the ContextMenu constructor? That is a layering violation in itself, ContextMenu can't know about ContextMenuController.

The two places in which it's needed inside our APIs are (WebKit/efl/ewk_contextmenu.c):

Eina_Bool ewk_context_menu_destroy(Ewk_Context_Menu* menu)
Eina_Bool ewk_context_menu_item_select(Ewk_Context_Menu* menu, Ewk_Context_Menu_Item* item)


With these functions we can respectively tell WebCore to destroy de ContextMenu and select an item. How would this be accomplished without access to the controller?

Should I go through page->contextMenuController()? I'm almost sure I can do this because there's a ref to webview in WebCore::ContextMenuClientEfl, but I need to check.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.