[Webkit-unassigned] [Bug 50422] [Qt] Canvas shadow offset should not be affected by any transformation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50422


Ariya Hidayat <ariya.hidayat at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76620|review?                     |review-
               Flag|                            |




--- Comment #29 from Ariya Hidayat <ariya.hidayat at gmail.com>  2010-12-14 21:47:09 PST ---
(From update of attachment 76620)
View in context: https://bugs.webkit.org/attachment.cgi?id=76620&action=review

> WebCore/platform/graphics/qt/ContextShadowQt.cpp:139
> +    const FloatSize clippedOffset = m_unclippedLayerOrigin - m_layerOrigin;
> +    const float translationX = -layerArea.x() + frameSize - abs(clippedOffset.width());
> +    const float translationY = -layerArea.y() + frameSize - abs(clippedOffset.height());
> +    m_layerContext->translate(translationX, translationY);

Having both m_unclippedLayerOrigin and m_layerOrigin will be confusing. In particular since we never need the former.

Here is an alternative: precompute the translation (as a point) in calculateLayerBoundingRect and save it and the use it later here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.